[MERGE] memory-tree and friends
John Arbash Meinel
john at arbash-meinel.com
Fri Sep 15 16:19:40 BST 2006
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Robert Collins wrote:
> This is an update of a previous approved patch to add MemoryTree and
> TreeBuilder, part of my test optimisation sweep.
>
> I think it should be fine still :)
>
> -Rob
v- I think we decided to put the 'from bzrlib import *' on multiple lines.
> +
> +from bzrlib import errors, mutabletree
> +from bzrlib.decorators import needs_read_lock, needs_write_lock
> +from bzrlib.osutils import sha_file
> +from bzrlib.mutabletree import needs_tree_write_lock
> +from bzrlib.transport.memory import MemoryTransport
> +
I seem to recall that my only concern was MutableTree not being tested
directly. However, for now, I'm fine with just explicitly testing all of
the instances. So +1 from me. (You can chose to cleanup that one line or
not)
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFFCsSMJdeBCYSNAAMRAta1AJsG0sPhV4LX0jt//GJRSEU9nqEsYACgv23R
Aq7FJqUEZ072OFooOUe0Rrg=
=bue/
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list