[BUG] NameError: global name 'ssh' is not defined

Alexander Belchenko bialix at ukr.net
Fri Sep 15 07:23:24 BST 2006


Andrew Bennetts пишет:
> Alexander Belchenko wrote:
>> On my win32:
> [...]
>> The problem occurs when I try to access to another branch via sftp:
> [...]
>>   File "E:\Bazaar\devel\bzr.dev\bzrlib\transport\ssh.py", line 104, in 
>> _get_ssh_vendor
>>     _ssh_vendor = ssh.ParamikoVendor()
>> NameError: global name 'ssh' is not defined
> 
> Oops, this would appear to be my fault.  I guess this means that the fallback to
> paramiko (when OpenSSH is not available) was broken by my recent refactoring of
> this code.
> 
> I've attached a bundle that should fix this, and a couple of other pyflakes
> nits in those files.  Clearly the tests are lacking though; we should probably
> make it so the ParamikoVendor is always tested, regardless of whether OpenSSH is
> available.  Or rather, test *every* available SSH implementation (and paramiko
> is a hard dependency, so it's always available).

+1 on this patch. I'd like to have it into bzr.dev.

--
Alexander





More information about the bazaar mailing list