[RFC] Ways to make initial knit creation faster (both push and commit)

[John Arbash Meinel]

Robert Collins wrote:

...

>> I've changed paramiko's trunk to avoid the stat() on files opened in  
>> append mode, postponing it until/if we need it (for example, seek()  
>> on an O_APPEND|O_RDWR file).  If you think it might still help, I'd  
>> appreciate any feedback.
> 
> Is this related to the revent data corruption for folk running paramiko
> head. The symptom is that all knits pushed to during a transaction end
> up without their kndx header line.
> 
> Rob

Yes. Robey has already reverted this change, and paramiko head does the
right thing again.

It turns out that openssh always respects the offset parameter by doing
an lseek, and it seems that lseeking on a file opened in append mode can
allow bytes to be written before the end. (It may be that the file is
opened in append + seek mode, or something like that)

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060911/b058a4e1/attachment.pgp