[MERGE/RFC] Add dotted-decimal revision numbers to merge_sorted output

[Robert Collins]

On Thu, 2006-09-07 at 03:07 -0400, Aaron Bentley wrote:
> Robert Collins wrote:
> > However, at the real world level, log is not fast enough to be affected
> > by this : log in a branch with 7K revisions is several orders of
> > magnitude slower than 80ms.
> 
> No, when log is displaying a restricted range (e.g. -r -20..-1), it
> takes ~60ms.  And it always emits a few log messages quickly, to fill
> the screen.  So for log formatters that show merges, slowing down
> merge_sorted could have an observable effect, because it increases the
> time before the first few log messages are emitted.
> 
> It probably makes sense to run the log benchmarks before and after.

Before:
running tests...
test_cmd_log               OK    71ms/36317ms
test_cmd_log_subprocess    OK   374ms/24164ms
test_log                   OK   599ms/24322ms
test_log_screenful         OK    74ms/23863ms
test_log_screenful_line    OK    48ms/24122ms
test_log_screenful_short   OK    31ms/24679ms
test_log_verbose           OK  1187ms/27523ms
test_merge_log             OK   155ms/46109ms

----------------------------------------------------------------------
Ran 8 tests in 231.113s

After:
running tests...
test_cmd_log               OK    81ms/25084ms
test_cmd_log_subprocess    OK   467ms/26084ms
test_log                   OK   620ms/26893ms
test_log_screenful         OK    84ms/27294ms
test_log_screenful_line    OK    49ms/27448ms
test_log_screenful_short   OK    34ms/26300ms
test_log_verbose           OK  1208ms/28204ms
test_merge_log             OK   160ms/48176ms

----------------------------------------------------------------------
Ran 8 tests in 235.497s

So slower, but not drastically so - I would say its within the margin
for noise on our measurements tbh.



before: time ./bzr log -r -3..-1 > /dev/null

real    0m0.935s
user    0m0.884s
sys     0m0.052s


after: time ./bzr log -r -3..-1 > /dev/null

real    0m1.003s
user    0m0.960s
sys     0m0.040s


So there is a performance hit. 70ms of real time, 10% of total execution
time. Whats the verdict ? [NB, once we have -r of dotted revnos, I'll
look at more performance tuning, but lets assume its as fast as its
going to get without radical surgery to the management of revisions -
thats a safe worst-case scenario.

Rob


-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060908/5bceb45f/attachment.pgp