[MERGE] Relocate the repository vfat escaping test.
John Arbash Meinel
john at arbash-meinel.com
Thu Sep 7 23:32:21 BST 2006
Robert Collins wrote:
> On Thu, 2006-09-07 at 13:44 -0500, John Arbash Meinel wrote:
>> Robert Collins wrote:
>>> This relocates and streamlines the repository vfat escaping test - it
>>> was a single branch test before, but in fact we need to test all
>>> repository implementations.
>>>
>>> Cheers,
>>> Rob
>>>
>>>
>> I'm a little concerned, because not all repository formats are actually
>> safe on VFAT. In fact, format 5 and 6 are not safe, because they don't
>> properly escape the disallowed characters. AFAIK only Knit1 is safe on
>> FAT32 with fancy characters.
>>
>> So unless I miss my guess, there is a problem with our vfat transport,
>> because it should be failing for some versions of the repository.
>
> Well, all tests pass - ?!.
>
> Rob
>
Something is wrong with the test. I forced it to fail and I inspected
the test directories.
And I saw that all of them are using Knit1 format repositories.
I think the specific problem is that you are inheriting from
TestCaseWithTransport, rather than TestCaseWithRepository.
John
=:->
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060907/40224033/attachment.pgp
More information about the bazaar
mailing list