[MERGE/RFC] Dotted-decimal revision numbers in 'bzr log'

[Robert Collins]

On Fri, 2006-09-08 at 00:40 +1000, Martin Pool wrote:
> On  7 Sep 2006, Robert Collins <robertc at robertcollins.net> wrote:
> 
> > Sample output for bzr.dev is here:
> > http://people.ubuntu.com/~robertc/baz2.0/sample-log.txt
> > 
> > I think it would be nice to remove the 'merged ...' lines from merged
> > revisions, but only once the dotted decimal revision-numbers are
> > accessible from commands like 'bzr diff' and 'bzr pull' etc.
> 
> I agree.  Obviously they should still be shown if --show-ids is given.
> 
> One other highly useful place for this would be in annotate output, which
> is quite hard to represent in text form at the moment.
> 
> I mentioned to Robert today that if this goes I think we should at least
> apologize that these are not accepted for -r parameters.  Otherwise it
> would just be very confusing.

Yah, I'll see how hard it is to get a good solution together to look
them up. I think that we want the branch to be responsible in api terms,
for the lookup.

> > === modified file 'bzrlib/tests/blackbox/test_log.py'
> > --- bzrlib/tests/blackbox/test_log.py	2006-07-28 16:05:23 +0000
> > +++ bzrlib/tests/blackbox/test_log.py	2006-09-07 03:24:18 +0000
> 
> Thanks for updating the example in this comment.  It seems to me that
> now we have assertEqualDiff we could compare the whole thing, if we just
> pass extra parameters to the commits to set the committer, time, 
> timezone and rev_id?  That would be nicer.

For now, I'd like to leave it - I dont think this test will gain a lot,
and it will be more complex to do.... I really want to get the doctest
pattern matcher into TestCase at some point which will give a good
balance.

> ...
> Surely api stability implies not changing the return type?

The return type is not changed unless you pass in 'generate_revno'.

If we make the generate_revno=False version deprecated, then users will
have a hint to change their code.

Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060908/aee49ad7/attachment.pgp