[RFC] Inventory.__delitem__ considered harmful

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> Inventory.__delitem__ is rather dangerous at the moment: it breaks the
> inventory invariant that all the parents of an entry are present in the
> inventory.
> 
> I'd like to just remove it with extreme prejuidice - any objections?

TreeTransform uses it: see TreeTransform._apply_removals.  Can we just
fix it so it doesn't violate that invariant?  I can't think of a better
way to express the functionality TreeTransform needs than del
inventory[file_id].

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFAAuE0F+nu1YWqI0RAvDJAJ96ITQt8Fl916VaTQx1M8gLO7H/fACfYruR
3t1Y9Vd80B8AtG4bmYMCEM4=
=MHRR
-----END PGP SIGNATURE-----