[MERGE] Test case for commit of deleted entries
Martin Pool
mbp at canonical.com
Thu Sep 7 10:30:18 BST 2006
On 7 Sep 2006, Robert Collins <robertc at robertcollins.net> wrote:
> Currently the behaviour of commit deleting entries from the working tree
> when the disk paths are missing is untested : no test
> matching .*test_commit.* fails when the code to do that is disabled or
> broken.
>
> This patch adds a test that it works, updating the tree memory inventory
> and the inventory on disk is correctly updated.
>
> This is the prep work for me fixing the unneeded inventory parsing
> during commit caused by the current layer interactions.
+1 but
> + def test_commit_deleted_subtree_and_files_updates_workingtree(self):
> + """The working trees inventory may be adjusted by commit."""
... or maybe not? Who knows? :-)
Can I suggest instead
"""Commit of deletion removes the entries from the working inventory."""
or maybe the method name by itself is sufficient - what else were you
trying to say?
--
Martin
More information about the bazaar
mailing list