[MERGE] Commit should not read the working tree inventory at the end

Robert Collins robertc at robertcollins.net
Thu Sep 7 09:44:11 BST 2006


This patch corrects the defect I noticed the other day, so that commit
no longer does a spurious parse of the working inventory.

running tests...
test_05_make_kernel_like_committed_tree           OK 63470ms/63646ms
test_cmd_commit                                   OK    31ms/   68ms
test_cmd_commit_subprocess                        OK   408ms/  445ms
test_commit_kernel_like_tree                      OK 44841ms/59495ms
test_commit_one_in_kernel_like_tree               OK  7151ms/84999ms
test_no_op_commit_in_kernel_like_tree             OK  6810ms/59737ms
test_partial_commit_kernel_like_tree              OK  5163ms/23559ms
test_partial_commit_one_in_kernel_like_tree       OK  6359ms/62072ms

running tests...
test_05_make_kernel_like_committed_tree           OK 71227ms/71453ms
test_cmd_commit                                   OK    71ms/  108ms
test_cmd_commit_subprocess                        OK   398ms/  437ms
test_commit_kernel_like_tree                      OK 38394ms/53236ms
test_commit_one_in_kernel_like_tree               OK  8204ms/73860ms
test_no_op_commit_in_kernel_like_tree             OK  7522ms/46380ms
test_partial_commit_kernel_like_tree              OK  4735ms/20668ms
test_partial_commit_one_in_kernel_like_tree       OK  8969ms/66913ms


Theres some noise in here - my laptop likes 10 second pauses to flush
*something*. But the overall shape is pretty clear - you should have no
trouble guessing which set of times is 'before' and 'after'.

Btw - martin, I think running the benchmarks 3 to 5 times on
benchmark.bazaar-vcs.org, and having the report script average the
figures, possibly even discarding the top/bottom ones (if we do 5 runs),
to get a single data point, might be of use.

-Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: commit-dont-read-tree-inventory.patch
Type: text/x-patch
Size: 2156 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060907/05723714/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060907/05723714/attachment.pgp 


More information about the bazaar mailing list