[MERGE] avoids preexec_fn on win32

John Arbash Meinel john at arbash-meinel.com
Wed Sep 6 18:09:47 BST 2006


Alexander Belchenko wrote:
...

> After successfully applying your bundle to bzr.dev revno.1986 I got the
> same error with preexec_fn.
> 
> -- 
> Alexander

I assume you only got those errors in the diff tests, and not in all the
rest of the tests. (You may have also gotten that error in some of the
gpg tests).

The attached patch should clean up the all of the cases where I wanted
to use preexec_fn. In general, where we were using it, it was to clean
up environment variables, which wouldn't be useful anyway on win32.

I tested it on a windows machine, and tests that used preexec_fn seem to
be passing now. (I still have problems with \r\n versus plain \n, but
the rest seem okay).

I'm putting together a patch to handle the $HOME issues, since we want
that fixed anyway. Which should fix all of the _set_user_ignores failures.

John
=:->
-------------- next part --------------
A non-text attachment was scrubbed...
Name: win32_no_preexec_fn.patch
Type: text/x-patch
Size: 22499 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060906/69b295d4/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060906/69b295d4/attachment.pgp 


More information about the bazaar mailing list