[PATCH] bzrlib API to add pending revision properties to a working tree

[John Arbash Meinel]

James Henstridge wrote:
> On 01/09/06, Martin Pool <mbp at canonical.com> wrote:

...

>> +1 on the facility.
>>
>> I don't think they should be called 'pending'.  From the PoV of the
>> working tree, they're just *the* revprops.  (Everything about the
>> working tree is in this sense pending.)
> 
> Okay, I chose the name to match "pending-merges", but I see those APIs
> seem to be wrappers around set/get_parent_ids() now.  So do you think
> get_revprops(), set_revprops() and add_revprop() would be better
> names?
> 
> James.


By the way, you shouldn't use the extension '.bundle'. Because mail
programs don't show them as text. It is better to use .diff or .patch,
since then we can review the patch just by reading the email.

I'll wait to review the second submission.

I really think we would rather spell out the names, though:

get_revision_properties()

Though I would prefer:

get_meta_properties() myself.

get_properties() seems too minimal and unclear.

I think pending-merges was back when we were deciding how we would
record merges (back in 0.0.1). Back when everything was in one .bzr/
directory (not split up by repository/branch/checkout). And it was
possible that we would have a 'pending-merges' for the working stuff,
and a 'merges' for the archived stuff. But we recorded it differently.

So pending is just because of legacy. :)

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060901/247495bd/attachment.pgp