[PING] updated benchmark display

[Carl Friedrich Bolz]

holger krekel wrote:
> On Tue, Aug 15, 2006 at 12:02 +1000, Robert Collins wrote:
>> There are some general stylistic issues with the patch:
>>  - please use self.assertTHING rather than 'assert' in the test suite.
>> We like our tests to run with -O [in principal]. More importantly is the
>> consistency with the rest of bzrlib and the improved diagnostics we get.
>>  - please put docstrings or comments in your tests explaining what and
>> why you are testing. They are rather bare at the moment.
>>  - please put docstrings on your functions outside the test suite too!
>>  - you have some duplicate code fragments in the tests that could well
>> be factored out - making the tests easier to read.
>>  - please put docstrings on classes. These are really essential when
>> trying to understand how you are intending to tie the various components
>> together.
> 
> please find a much updated diff attached and some
> selected inline comments further below.  Our branch
> is also available at 
> 
>     http://codespeak.net/bzr/benchmark-display.merge1 

Could someone please look at this branch again? We think it is close to
merging and Martin said on IRC that he liked the output. It is
registered at launchpad as bench-display. I also attached the diff.

Cheers,

Carl Friedrich

-------------- next part --------------
A non-text attachment was scrubbed...
Name: benchmark-display.patch
Type: text/x-patch
Size: 49500 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060831/b23cee0e/attachment.bin