[MERGE] remove has_key() usage

John Arbash Meinel john at arbash-meinel.com
Wed Aug 30 16:00:04 BST 2006


Robey Pointer wrote:
> 
> On 29 Aug 2006, at 14:35, John Arbash Meinel wrote:
> 
>> Robey Pointer wrote:
>>> I've posted a branch at:
>>>
>>>     http://www.lag.net/~robey/code/bzr.dev.no_has_key/
>>>

...

> In the branch, I also fixed the 'return' statements, to use explicit
> parens.

I didn't see this email, so I had already merged the bundle, and
submitted it to the pqm. after fixing up the return statements. :)

> 
> I may try the same thing with replacing hasattr(), unless this kind of
> janitorial work is annoying people.
> 
> robey

I think it is fine. And I think we are happy to get the code cleaned up.
If you want some more things to look for, we also need to remove
trailing whitespace from lines. Though that may be a more controversial
change, since it messes up annotations.

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060830/6aba4917/attachment.pgp 


More information about the bazaar mailing list