[MERGE] remove has_key() usage
Aaron Bentley
aaron.bentley at utoronto.ca
Wed Aug 30 00:45:03 BST 2006
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Martin Pool wrote:
> On 29 Aug 2006, Aaron Bentley <aaron.bentley at utoronto.ca> wrote:
>> I think my favorite is bool(file_id in self._byid)
>
> Why? For extra explicitness that it must be a bool, or do you really
> expect that 'in' might return something unsuitable?
Yes, for the extra explicitness. Extra parens just don't telegraph it
to me. But I can go with John's, if you prefer that.
Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFE9NF/0F+nu1YWqI0RAp2AAJwNPhWjvBPFsabL5CnFltU3jGpwmwCeL6qw
XSCS2CiKfwmwunkhwdQ9/ks=
=Cb3n
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list