[MERGE] remove has_key() usage

Aaron Bentley aaron.bentley at utoronto.ca
Tue Aug 29 22:56:10 BST 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> I think for a return value, I prefer:
> 
> return (file_id in self._byid)
> 
> Because I think it makes it a little bit clearer that you aren't
> returning the file_id.

I think my favorite is bool(file_id in self._byid)

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFE9Lf60F+nu1YWqI0RAkodAJ9dPi7C2gGSz+ZEuVIKQWfmNdx3VgCfWK//
3T2MiVKqsnepDlc86TB/03c=
=apQB
-----END PGP SIGNATURE-----




More information about the bazaar mailing list