[BUG] bzr selftest failure

[John Arbash Meinel]

Matthieu Moy wrote:
> On a machine without paramiko installed, "bzr selftest" fails
> (bzr.dev, which is same as 0.10rc1 today). IIRC, it has worked
> correctly before.
> 

Does this patch work for you?

=== modified file 'bzrlib/tests/test_sftp_transport.py'
--- bzrlib/tests/test_sftp_transport.py 2006-08-25 07:31:08 +0000
+++ bzrlib/tests/test_sftp_transport.py 2006-08-29 20:27:22 +0000
@@ -403,6 +403,8 @@

     def setUp(self):
         TestCase.setUp(self)
+        if not paramiko_loaded:
+            raise TestSkipped('you must have paramiko to run this test')

     def test_delay(self):
         from bzrlib.transport.sftp import SocketDelay


Basically, the above just skips the SocketDelay tests if paramiko isn't
installed, because SocketDelay is in sftp.py which requires paramiko
before it can be imported. (I suppose we should really move SocketDelay
into a different file).



> $ ./bzr --no-plugins selftest                                                                     
>        bzr: /net/ecrins/local/moy/usr/src/bzr/bzr.dev/bzr
>     bzrlib: /net/ecrins/local/moy/usr/src/bzr/bzr.dev/bzrlib
> 
> running tests...
> /net/ecrins/local/moy/usr/src/bzr/bzr.dev/bzrlib/transport/ftp.py:728: UserWarning: You must install medusa (http://www.amk.ca/python/code/m
> edusa.html) for FTP tests                                                                                                                  
>   warn("You must install medusa (http://www.amk.ca/python/code/medusa.html) for FTP tests")
> bzrlib.tests.test_setup.TestSetup.test_build_and_install: FAIL                                                                              
> bzrlib.tests.test_sftp_transport.TestSocketDelay.test_bandwidth: ERROR                                                                      
> bzrlib.tests.test_sftp_transport.TestSocketDelay.test_delay: ERROR                                                                          

I'm not sure why 'test_build_and_install' would fail, though. And the
traceback doesn't make anything clear.

John
=:->


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060829/6b6fc876/attachment.pgp