Extra test [Re: [MERGE][0.10] Fix list_dir quoting in SFTPTransport and FTPTransport]

[Robert Collins]

On Tue, 2006-08-29 at 12:09 +1000, Andrew Bennetts wrote:
> John Arbash Meinel wrote:
> > Robert Collins wrote:
> > > On Mon, 2006-08-14 at 12:07 -0500, John Arbash Meinel wrote:
> > > 
> > > +1 from me two, if you integrate Andrews and Davids work - or perhaps
> > > Andrew could do that as its in the critical path for the smart server.
> > > 
> > > +1 either way.
> > > 
> > > Cheers,
> > > Rob
> > 
> > Attached is a bundle which merges Andrew's changes and David's changes,
> > and a few clean ups of my own.
> [...]
> 
> I see this has been merged, which is good.  There's one hunk of my changes that
> didn't get included:
> 
> === modified file 'bzrlib/tests/test_transport_implementations.py'
> --- bzrlib/tests/test_transport_implementations.py      2006-08-25 22:27:04 +0000
> +++ bzrlib/tests/test_transport_implementations.py      2006-08-29 02:04:40 +0000
> @@ -773,6 +773,20 @@
>          self.assertListRaises(PathError, t.list_dir, 'c/f')
>          self.assertListRaises(PathError, t.list_dir, 'a')
> 
> +    def test_list_dir_result_is_url_escaped(self):
> +        t = self.get_transport()
> +        if not t.listable():
> +            raise TestSkipped("transport not listable")
> +
> +        if not t.is_readonly():
> +            self.build_tree(['a/', 'a/%'], transport=t)
> +        else:
> +            self.build_tree(['a/', 'a/%'])
> +
> +        names = list(t.list_dir('a'))
> +        self.assertEqual(['%25'], names)
> +        self.assertIsInstance(names[0], str)
> +
>      def test_clone(self):
>          # TODO: Test that clone moves up and down the filesystem
>          t1 = self.get_transport()
> 
> 
> I think this is still useful -- it's good to have short and focused tests.  I
> think this should be merged into 0.11.

+1. Wheres the branch I can pull this to merge from ?

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060829/cb2a8952/attachment.pgp