[MERGE] run_bzr_subprocess(env_changes={})

[John Arbash Meinel]

Martin Pool wrote:

...

>> Maybe BZR_PROGRESS_BAR. But I don't think it should do anything with
>> LANG, as it isn't something that needs to be tested often.
>>
>> I suppose instead we could pass environment vars to set/unset as part of
>> run_bzr_subprocess.
> 
> That sounds good.  In general setting them while the process is
> running is not a good idea.  (For example some systems scan $TZ at
> libc startup and some every time it's needed.)  So
> 
>   run_bzr_subprocess(...,
>       env_changes = {"REMOVE_ME": None, "LANG": "de_DE"})
> 

I went ahead and merged the locale changes, since they had been
approved, but I liked the idea of this, so I went ahead and updated
run_bzr_subprocess, the locale tests, and added a direct test for this
that the environment changes are used, but don't stick in the parent.

Attached is a bundle.

John
=:->
-------------- next part --------------
A non-text attachment was scrubbed...
Name: run_bzr_subprocess.patch
Type: text/x-patch
Size: 6751 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060828/1f121290/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060828/1f121290/attachment.pgp