[MERGE] unclutter progress bars when using GPG

[John Arbash Meinel]

Aaron Bentley wrote:
> Here's a simple patch to fix the output of commit when using GPG
> signing.  Right now, I get this:
> 
> ===
> deleted bzrlib/util/urlgrabber/mirror.py
> deleted bzrlib/util/urlgrabber/progress.py
> / [========================================================] Committing
> 463/467Reading passphrase from file descriptor 4
> 
> You need a passphrase to unlock the secret key for
> user: "Aaron Bentley <aaron.bentley at utoronto.ca>"
> 1024-bit DSA key, ID 5616A88D, created 2004-12-08
> 
> Committed revision 1672.
> ===
> 
> With the patch, I get this:
> 
> ===
> modified bzrlib/gpg.py
> Reading passphrase from file descriptor 4
> 
> You need a passphrase to unlock the secret key for
> user: "Aaron Bentley <aaron.bentley at utoronto.ca>"
> 1024-bit DSA key, ID 5616A88D, created 2004-12-08
> 
> Committed revision 1673.
> ===
> I don't think this needs a test case, and I'm not sure how to do it,
> anyhow, because of GPG's bizarre interactions with the console.
> 
> Aaron

+0.5 from me. I think it is 0.10 worthy, but if you are unsure, wait for
Robert.

The only thing I can think of to test it, would be to use an
instrumented ui_factory, and an instrumented dummy gpg signing routine.
And just make sure that the right functions end up getting called.

If it had a test, it would be a straight +1. (And you might be able to
sneak it anyway)

John
=:->


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060825/6150d295/attachment.pgp