[MERGE] Refactor loopback/paramiko/openssh/ssh connection opening

[Andrew Bennetts]

On Fri, Aug 25, 2006 at 04:24:03PM +1000, Robert Collins wrote:
> On Fri, 2006-08-25 at 15:54 +1000, Martin Pool wrote:
> > 
> > > +def os_specific_subprocess_params():
> > > +    """Get O/S specific subprocess parameters."""
> > 
> > Could this move to an instance method of SubprocessVendor? 
> > 
> > It's also called from the code that runs 'ssh -V', but setting these
> > options is not really needed to get the version. 
> 
> I'd be wary of putting O/S things in the same hierarchy as vendor
> changes.
> 
> I'd be more inclined to have parameterised vendors, with an os flavour
> class instead - that will give more combinations with less duplication.

You might be right.  I'm inclined leave it as is for now -- simple (although
slightly ugly and inflexible) -- until we have a need to improve it.  When we
need it, then we'll have a clear idea of what shape it should take.

-Andrew.