[merge] Handle bad LANG

[Robert Collins]

On Thu, 2006-08-24 at 16:47 -0500, John Arbash Meinel wrote:
> Right now if you set LANG to something unrecognized by python, you get
> an ugly traceback.
> 
> The attached patch changes bzrlib so it falls back to just using 'ascii'
> after emitting a semi-helpful warning.
> 
> I'm not 100% on the english of the warning, but I think it is reasonable.
> 
> This is probably small enough for 0.10, but I'll let Robert decide.
> 
> My only concern is that the test might be a little too brittle, because
> it expects a specific formatting for the locale.Error.

+1 for 0.11, not for 0.10 - it assumes LANG is everywhere and I'm
suspecting thats not fit for windows.

Also, looking at the test, why doesn't run_bzr_subprocess take care of
the LANG and BZR_PROGRESS_BAR options rather than the test doing it ?
That would seem cleaner and more reusable to me.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060825/fc6b3851/attachment.pgp