[MERGE] Refactor loopback/paramiko/openssh/ssh connection opening
Robert Collins
robertc at robertcollins.net
Fri Aug 25 07:24:03 BST 2006
On Fri, 2006-08-25 at 15:54 +1000, Martin Pool wrote:
>
> > +def os_specific_subprocess_params():
> > + """Get O/S specific subprocess parameters."""
>
> Could this move to an instance method of SubprocessVendor?
>
> It's also called from the code that runs 'ssh -V', but setting these
> options is not really needed to get the version.
I'd be wary of putting O/S things in the same hierarchy as vendor
changes.
I'd be more inclined to have parameterised vendors, with an os flavour
class instead - that will give more combinations with less duplication.
-Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060825/a925d28d/attachment.pgp
More information about the bazaar
mailing list