remove LocalAbspathServer, LocalRelpathServer
John Arbash Meinel
john at arbash-meinel.com
Thu Aug 24 23:16:13 BST 2006
Martin Pool wrote:
> This is a small cleanup in response to previous review comments. We
> discovered that running tests three times for local paths was a waste,
> because the only difference is in how the transport is initialized.
> With this change applied, we just directly test constructing transports
> from paths, and then run the lower-level tests just once.
>
> Since local path tests are pretty fast this only saves a few seconds
> from the test suite time. More importantly it reduces duplication, and
> lets us move more things towards get_url actually returning a URL,
> rather than sometimes a url and sometimes a path.
>
> This isn't intended for 0.10 but I'd like to hear if there's any reason
> not to remove them or continue on that path.
>
I don't see any tests doing "directly test constructing transports from
paths". I just see the removal of the other transport servers.
+1 on removing them from me. But I'd like to see the other things tested
first.
John
=:->
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060824/ae5ca005/attachment.pgp
More information about the bazaar
mailing list