[MERGE] RevisionSpec.in_history() should raise nicer errors

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> On Wed, 2006-08-23 at 15:22 -0500, John Arbash Meinel wrote:
>> Currently with bzr, if you do 'bzr log -r10000' you get a NoSuchRevision
>> exception, which is an internal exception, meant for indicating you are
>> missing something from your repository.
>>
>> Also, it turned out that while we tested the very basic revision spec
>> functionality, we didn't do much error or edge case testing.
>>
>> The attached patch adds a new error: InvalidRevisionSpec, which gets
>> formatted into a much nicer user error.

I'm in favor of this direction, but I haven't reviewed the code closely
enough to give a +1.  I figured the changes were too much for 0.10, but
decided to wait and see what Robert said.

> So I'd rather say 'lets get this really right for 0.11 and not change
> for 0.10'.

These NoSuchRevision errors are a pretty big wart.  Should we consider
catching them in as a special case in 0.10?  That would be a very small
modification.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFE7NR10F+nu1YWqI0RAsPHAJ4s65kL/0S4UE+UF22sv5UqVLQKMwCeMOh8
TgqOF4tj/nbeJyGvPkqcnio=
=m8E6
-----END PGP SIGNATURE-----