[MERGE] RevisionSpec.in_history() should raise nicer errors
aaron.bentley at utoronto.ca
Wed Aug 23 23:19:33 BST 2006
-----BEGIN PGP SIGNED MESSAGE-----
Robert Collins wrote:
> On Wed, 2006-08-23 at 15:22 -0500, John Arbash Meinel wrote:
>> Currently with bzr, if you do 'bzr log -r10000' you get a NoSuchRevision
>> exception, which is an internal exception, meant for indicating you are
>> missing something from your repository.
>> Also, it turned out that while we tested the very basic revision spec
>> functionality, we didn't do much error or edge case testing.
>> The attached patch adds a new error: InvalidRevisionSpec, which gets
>> formatted into a much nicer user error.
I'm in favor of this direction, but I haven't reviewed the code closely
enough to give a +1. I figured the changes were too much for 0.10, but
decided to wait and see what Robert said.
> So I'd rather say 'lets get this really right for 0.11 and not change
> for 0.10'.
These NoSuchRevision errors are a pretty big wart. Should we consider
catching them in as a special case in 0.10? That would be a very small
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v18.104.22.168 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the bazaar