[MERGE] fix up test_bench_history

Martin Pool mbp at canonical.com
Wed Aug 23 04:08:46 BST 2006

On 22 Aug 2006, Aaron Bentley <aaron.bentley at utoronto.ca> wrote:
> John Arbash Meinel wrote:
> > This seems more like a bug fix to the assertDeprecated API, because I
> > think you meant for the API to do this all along. Right?
> Right.
> > Hence, it is a real bugfix, not an API change, and thus is +1 for 0.10.
> Thanks, submitted.

It's OK with me for 0.10 if it fixes the API to do what it should.  

It seems a little strange to me to have an assert* routine return the
result of the thing it called.  If the point is to call the thing and
incidentally check it's deprecated perhaps it should be


More information about the bazaar mailing list