[MERGE] Improvements to test_bzrdir

[Martin Pool]

On 18 Aug 2006, Andrew Bennetts <andrew at canonical.com> wrote:
> On Fri, Aug 18, 2006 at 04:59:41PM +1000, Robert Collins wrote:
> > On Fri, 2006-08-18 at 15:26 +1000, Andrew Bennetts wrote:
> > > -        target = dir.sprout(self.get_url('target'))
> > > +        try:
> > > +            target = dir.sprout(self.get_url('target'))
> > > +        except errors.NotLocalUrl:
> > > +            raise TestSkipped('Cannot sprout to remote bzrdirs.')
> [...]
> > 
> > 
> > This is still somewhat redundant...
> > 
> > would be nice to have this block factored out too (it appears a number
> > of times).
> 
> Ok, I didn't do this initially because I didn't want to replicate all the
> arguments to sprout in a helper.  Having done it anyway, you're right, it is
> much better with the helper, and I was just being lazy :)
> 
> I'm pushing up to the same location.  Here's the incremental patch.

Oh yes, certainly much better. +1

-- 
Martin