[merge] setup.py should find the packages automatically

[John Arbash Meinel]

Alexander Belchenko wrote:

...

> John, I'm +1 in concept. But your implementation is not working:
> 
> $ python setup.py build
> Traceback (most recent call last):
>   File "D:\user\MyCode\bzr\sandbox\fix-setup-py\setup.py", line 26, in ?
>     BZRLIB = {'packages':get_bzrlib_packages()}
> NameError: name 'get_bzrlib_packages' is not defined
> 
> This also catched by test_setup test. Run:
> 
> python bzr selftest test_setup
> 
> and you'll see ;-)
> 
> Function *should be* defined prior to use. Need to rework your patch.
> I'm -1 on current patch.

Well, naturally I shouldn't get anything accepted that doesn't work :)

Oddly enough I did do some manual testing, but that was probably at an
intermediate stage. I did test that get_bzrlib_packages() returns the
right package list...

> 
> I'm also -1 on making function definition on top of setup.py because I
> specially move all setup-related meta info to the top of file to easy
> search, read and edit when necessary. May be move this function to
> bzrlib/__init__.py?

I don't think something like this belongs in bzrlib proper. I do
understand your point about wanting the basic information at the top in
a clean, easy to read and modify section. And I like that. I'm thinking,
though, that since BZRLIB is now automatically generated, I'll just
leave a stub at the top, and do the auto-generate after the function
declaration.

I think things are still clean, so I'm submitting it. But I'm attaching
a bundle to show the changes. If someone doesn't like it, I'm willing to
update it.

John
=:->


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060817/d44d805d/attachment.pgp