[MERGE] trivial NotImplementedError and docstring tweaks

Martin Pool mbp at canonical.com
Thu Aug 17 07:37:04 BST 2006


On 17 Aug 2006, Robert Collins <robertc at robertcollins.net> wrote:
> On Thu, 2006-08-17 at 13:40 +1000, Robert Collins wrote:
> > On Thu, 2006-08-17 at 13:37 +1000, Andrew Bennetts wrote:
> > > This patch mainly updates a bunch of NotImplementedErrors in bzrlib/branch.py
> > > from this style:
> > > 
> > >         raise NotImplementedError('foo is abstract')
> > > 
> > > to this:
> > > 
> > >         raise NotImplementedError(self.foo)
> > > 
> > > Also, there's some minor PEP 8 nits in bzrlib/transport/sftp.py.
> > 
> > +1
> (I should note, I am here with Andrew and read the patch he FAILED TO
> SUPPLY on his screen).

Since this happens fairly regularly there is room for automating the
process of:

 - make a bundle from (by default) bzr.dev to the proposed changes
 - prompt for a text explanation
 - sign it (maybe?)
 - send it to the list

...

I think SubmitByMail will do this, except perhaps for asking for
explanation additional to the commit messages.  Or maybe it even does
that?

-- 
Martin




More information about the bazaar mailing list