[MERGE] Make some tests use test suite transport rather than local
Robert Collins
robertc at robertcollins.net
Thu Aug 17 05:23:26 BST 2006
On Thu, 2006-08-17 at 14:06 +1000, Andrew Bennetts wrote:
> On Thu, Aug 10, 2006 at 07:07:57PM +1000, Robert Collins wrote:
> > On Thu, 2006-08-10 at 18:56 +1000, Andrew Bennetts wrote:
> [...]
> > > > +1 with a comment : the try: block seems rather large. Wouldn't it be
> > > > fine with just the made_tree line inside the try ?
> > > >
> > > > (remember - NotLocalUrl is only raised from the tree related calls, no
> > > > branch/repo or control.)
> > >
> > > That's what I tried initially, but the made_control line also raised that
> > > exception.
> >
> > That would be a bug in the legacy all-in-one format I guess.
> >
> > What format raised it ?
>
> Excellent question. I can't reproduce the problem now, so I've narrowed the
> try-block back down to just the create_workingtree line, and everything's happy.
> I guess it was a bug in something else I was doing at the time.
>
> I've attached the updated patch.
+1 with the same caveat your patch earlier today has - the duplicated
test blocks should be factored out.
-Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060817/6859f277/attachment.pgp
More information about the bazaar
mailing list