[Merge] Slow socket

[Robert Collins]

On Tue, 2006-08-15 at 18:37 -0500, John Arbash Meinel wrote:
> 
> I know what Robert said, though I disagree with him.
> To me 'from bzrlib import' is (bzrlib, '') not (bzrlib, import). While
> and the other is (bzrlib, branch).
> Now, your original form was still wrong, because the last line is
> (bzrlib, tests, TestUtil). So *I* think it needs to go inbetween:
> 
>  from bzrlib import (
> +    bzrdir,
>      plugin,
>      )
> +import bzrlib.branch
>  from bzrlib.tests.TestUtil import TestLoader


I wasn't very clear.

from bzrlib import is (bzrlib, '') to me too.

The hunk I was looking at appeared to have a bzrlib.i??? section in it
IIRC.

The only other comment I've got is that <3 letter variable names
are /really/ hard for people to read. 

wt sort of sneaks through, but even it is not desirable.

Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060816/c480e287/attachment.pgp