[PATCH] ignore log to stdout in benchmarks

[Robert Collins]

On Tue, 2006-08-15 at 18:47 -0500, John Arbash Meinel wrote:
> 
> I don't know whether it is better to read the log file, and cache the
> contents and always delete the log file, or to do it as you have done.
> My concern is that the log file might go into /tmp, in which case it
> really needs to be deleted, so that we don't clutter up /tmp.
> 
> We already have too much leakage into /tmp. I currently have 95
> testbzr*.log files in /tmp.
> 
> I'm guessing that if a test fails, or if a test explicitly requests
> that
> the log file is kept, then it is okay to buffer the contents in
> memory.

I was suggesting the following:
By default:
 - successful or skipping tests delete the log from disk and throw away
the contents
 - failing or erroring tests put the log on disk until get_log_content()
is called, when they read the file into memory and delete the log from
disk.

Tests that need to can request that the log on disk be explicitly kept.

-Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060816/776d0df2/attachment.pgp