[PATCH] ignore log to stdout in benchmarks

Carl Friedrich Bolz cfbolz at gmx.de
Wed Aug 16 00:30:24 BST 2006

Robert Collins wrote:
> Is there any reason this should not be done to bzrlib.tests.TestCase ?

Basically we thought the way it is done now is there for a reason :-)

> That is
>  - change the default test case finishLogFile to delete the in memory
> copy.
>  - Add a method 'getLogFileContents()' which will read the log file from
> disk.
>  - Add a method 'setKeepLogFile()' which if called tells finishLogFile
> to unlink the file from disk rather than just closing it.

setKeepLogFile would make the file being unlinked? You mean the other
way round, right?

> I think this would be a bit cleaner and generally more useful - it would
> reduce memory footprint during regular bzr selftest too.

I tried to implement something like that, see attached patch.


Carl Friedrich

-------------- next part --------------
A non-text attachment was scrubbed...
Name: dontkeeplog.patch
Type: text/x-patch
Size: 2140 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060816/9834dfbd/attachment.bin 

More information about the bazaar mailing list