performance-history patch

Martin Pool mbp at canonical.com
Tue Aug 15 15:02:34 BST 2006


Jan's patch to record performance history to a file got some +1s before
with comments, so I'm going to review it and send it in.

I did have one change, which is 

=== modified file 'bzrlib/tests/__init__.py'
--- bzrlib/tests/__init__.py	2006-08-15 12:39:42 +0000
+++ bzrlib/tests/__init__.py	2006-08-15 13:41:41 +0000
@@ -142,9 +142,9 @@
         unittest._TextTestResult.__init__(self, stream, descriptions, verbosity)
         self.pb = pb
         if bench_history is not None:
-            #XXX is there a simpler way to get the revison id?
-            branch = bzrlib.branch.Branch.open_containing('.')[0]
-            revision_id = RevisionSpec(branch.revno()).in_history(branch).rev_id
+            # XXX: If there's no branch, what should we do?
+            branch = bzrlib.branch.Branch.open_containing(__file__)[0]
+            revision_id = branch.last_revision()
             bench_history.write("--date %s %s\n" % (time.time(), revision_id))
         self._bench_history = bench_history
     


-- 
Martin




More information about the bazaar mailing list