PING [MERGE] Root entry has a revision id

[John Arbash Meinel]

Aaron Bentley wrote:
> I haven't heard anyone's opinion of this, and I think it's a bit too
> major for me to just merge without review.
> 
> This is a blocker for the format bump.  The dependencies are
> 
> nested-trees requires unique-root-id
> unique-root-id requires format-bump
> format-bump requires root-has-revision
> 
> Aaron

I wasn't commenting on it, because it has too much of the root == None
stuff, which you need to sort out between you and Robert.

The one thing I didn't like was using 'NewCommitBuilder' as the class
name. If it is truly meant to be temporary, then I think using
'_CommitBuilder' would be better.
Though the way you were writing it, you really should have done the
changes in NewCommitBuilder, rather than in the base class.

Otherwise you are changing a base implementation, away from classes that
are using it.

The changes themselves seemed okay. (I didn't see any PEP8 issues, etc)

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060814/3900839e/attachment.pgp