[MERGE] Tests fail if BZR_EMAIL is set

Martin Pool mbp at canonical.com
Mon Aug 14 11:21:55 BST 2006


On 14 Aug 2006, Adeodato Simó <dato at net.com.org.es> wrote:
> Hi all.
> 
> I was experiencing failures in random tests, and I finally narrowed it
> down to the BZREMAIL -> BZR_EMAIL migration.
> 
> The code in config.py checks for $BZR_EMAIL and, if present, just
> returns it, without looking up whether $BZREMAIL exists. This is good,
> because compatibility with 0.8 can be achieved by just setting both
> variables to the same value.
> 
> However, _cleanEnvironment() in tests/__init.py__ only clears BZR_EMAIL,
> and not BZREMAIL, which leads to failures in tests that check the error
> output.
> 
> I think it'd be good to fix this, to have the transition be a truly
> clean one.
> 
>   http://people.debian.org/~adeodato/code/branches/bzr/tests_unset_bzremail

Thnaks.  +1, will merge it.

-- 
Martin




More information about the bazaar mailing list