[patch] warn on deprecated formats

Robert Collins robertc at robertcollins.net
Fri Aug 11 11:42:28 BST 2006


On Fri, 2006-08-11 at 19:10 +1000, Martin Pool wrote:
> +    def _warn_if_deprecated(self):
> +        global _deprecation_warning_given
> +        ## if _deprecation_warning_given:
> +        ##     return
> +        _deprecation_warning_given = True
> +        warning("Format %s for %s is deprecated - please use 'bzr
> upgrade' to get better performance"
> +                % (self._format, self.bzrdir.transport.base))

Looks good except for the _deprecation_warning_given flag which is
unneeded :).

I think we want something more selective in 0.10, but this is better
than nothing - I've been running into lots of users using weaves and
complaining about performance.

Thanks,
Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060811/89a6c1bf/attachment.pgp 


More information about the bazaar mailing list