[MERGE] make plugins use the right suffixes

[Robert Collins]

On Wed, 2006-08-02 at 10:51 +1000, Martin Pool wrote:


> I'm somewhat squeamish at having no visible message for import failures
> -- the user will just see it apparently ignore a new plugin if it's not
> just right.  In particular if you put in a module called say
> 'bzrtools.abentley' then it will try to load the first part, fail, and
> ignore it.
>
> Why not just give a warning for all of them?  If it's because there are
> some file extensions (.py~) which should clearly be ignored, then we
> should filter by extension when building the candidates.

I'm also happy to warn on all. I put in the filtering because you
mentioned that warning on cruft was possibly unpleasant. My preference
would be to just warn to stderr on all failures from the plugins
directories.

> > > For modules ending in 'module.' we could also create 2 entries. foo and
> > > foomodule, preferring to load the first form. (Very few people would
> > > name their module foomodule.py).
> > 
> > We could, so the question is 'which form of confusion is better' :). I'm
> > inclinded to say 'supporting foomodule.so is worse' simply because itse
> > more code for us.
> 
> So can you have a C or Pyrex extension just called foo.so or foo.dll?

Yes. Thats the common mode of making them in fact. (btw, its foo.pyd on
windows :)).


-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060802/31952856/attachment-0001.pgp