[merge] benchmark caching

[Robert Collins]

On Wed, 2006-08-09 at 11:40 -0500, John Arbash Meinel wrote:
> I originally tried to break the patches down into incremental updates.
> But since I didn't get any responses, and I had to make another update,
> I'm just submitting the whole thing to be reviewed.
> 
> summary:
>   new functions on Benchmark, which can grab a cached kernel-like tree
> in various states. Makes test setup time *much* more reasonable. It also
> allows the cache to be preserved between runs.
>   I also added support for creating the kernel-like tree somewhere other
> than '.'. Which will help for certain tests that need to create more
> than one tree.
> 
> new changes:
>   The old code base had just done a 'bzr add', which yields a hot
> hash-cache, so for tests to be consistent, we need to warm it up after
> copying the tree.

I'm -0 on the caching, +1 on the new benchmarks.


I'm -0 on the caching because I think that there is too much risk of
generating unexpected benchmark results - ones that do not match what
the code *appears* to do. For instance - you've had to add code to warm
up the hash cache. 

I'd rather we made doing commits and builds faster, than stop doing them
in each benchmark.

Rob


-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060810/063b4b76/attachment.pgp