[merge] accept LogFormatter instances in cmd_log.run

Aaron Bentley aaron.bentley at utoronto.ca
Fri Jul 28 14:40:32 BST 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Adeodato Simó wrote:
> Another one that strikes me as sensible is having cmd_log.run accept a
> LogFormatter instance in the log_format argument. The rationale is the
> following: one can, of course, create a CustomLogFormatter class,
> register it, and call log with log_format='custom_format'. However, this
> is of little use when one wants the class to collect data, since there
> is no way to retrieve the created CustomLogFormatter instance back from
> cmd_log.run().

In general, you shouldn't be calling cmd_log.run.

The purpose of that function is to decode commandline parameters and
invoke the underlying functionality, i.e. show_log.  (Which *does*
accept a log formatter, of course.)

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFEyhPQ0F+nu1YWqI0RAojRAJ46+mPaXrC7hsHpmPvdCxNUC1WjbwCeIs5B
SKV1E3boUXV4W355qKzs3yo=
=bvCK
-----END PGP SIGNATURE-----




More information about the bazaar mailing list