[MERGE] fix xml5 serializer with empty property values

[Robert Collins]

On Thu, 2006-07-27 at 18:39 -0500, John Arbash Meinel wrote:
> Robert Collins wrote:
> > On Thu, 2006-07-27 at 16:49 -0500, John Arbash Meinel wrote:
> >> +    * When reading revision properties, and empty value should be
> >> considered
> >> +      the empty string, not None (John Arbash Meinel, #47782)
> > 
> > This seems like something that will vary with different backends, and
> > should be a repository interface test.
> > 
> > -Rob
> > 
> 
> I am actually testing it at a higher level. As in the 'tree.commit()' level.
>
> Did you want it in repository_implementations?
> 
> I can add a test there as well.

Short answer yes.

Long answer: here is a classic example of why testing at high levels
leads to untested code. The bug we want to exercise is in code that
varies between 'Repository' implementations. So we need to exercise that
corner case once for each Repository. (Perhaps we could be finer grained
and say once per serialisation type, but we dont discriminate at that
level yet).

So triggering the test via 'tree.commit()' is fine, but the combinations
to test must be driven by the Repository interface implementations -
thus it should be a repository_implementations test, and no test is
needed in test_revision - as it does not cover our code base well there.

Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060728/6a624144/attachment.pgp