[BUG?] revisiontree's root node has no revision attribute set

[Robert Collins]

On Thu, 2006-07-27 at 09:46 -0400, Aaron Bentley wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> John Arbash Meinel wrote:
> > I think for the nested tree work, we would want it to have the revision
> > id of the last commit. But that makes it different from all the other
> > directory nodes.
> 
> For nested by-reference trees, we'll need a new node type, say
> ChildRoot.  So in the child, the root would be a normal directory, but
> in the parent, it would be a ChildRoot, and its .revision could come
> from WorkingTree.last_revision.

I think its revision is separate to the wt last-revision. We need two
revision values:
1) to record the time its name and parent-id and type was set in this
tree
2) to record the revision id of the subtree - which is the
WT.last_revision.

I've been modelling this as ChildRoot.contents == (2), and
childRoot.revision is updated when anything, including the contents
change - this is consistent with files and symlinks.

> I don't think we need consistency between the ChildRoot.revision and the
> InventoryDirectory.revision, and I'd prefer to make the
> InventoryDirectory for the root behave like all other InventoryDirectories.

I agree.

Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060728/334255a7/attachment.pgp