[MERGE] fix xml5 serializer with empty property values

John Arbash Meinel john at arbash-meinel.com
Thu Jul 27 22:49:09 BST 2006


The current serializer expects all revision properties to have string
keys and values when writing out.

However, because of how they are stored, when reading in, an empty
string is translated into None. (they are the 'text' property, and there
is no text for the empty string).

The attached patch adds a test for this, and a fix.

It also makes sure that revision properties can be round tripped. Which
is something that Jamie might need to update with his Graft plugin.
I don't know if he is copying revision properties or not, but since he
wrote the test, and he wasn't testing for it, I'm guessing he isn't.

This probably fixes bug:
https://launchpad.net/products/bzr/+bug/47782

But I would need to actually use that branch to know for sure. (But
judging on where it is failing, that should be the case)

John
=:->
-------------- next part --------------
A non-text attachment was scrubbed...
Name: empty_property_value.patch
Type: text/x-patch
Size: 7488 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060727/cf4880d5/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060727/cf4880d5/attachment.pgp 


More information about the bazaar mailing list