[BUG?] revisiontree's root node has no revision attribute set

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> For a RevisionTree, for any entry you can use 'entry.revision' to get
> the last changed revision.
> 
> We dont currently set that for the root node.
> 
> I think a reasonable change for this is to start by setting it to the
> revision_id of the revision tree.

Isn't the revision_id for directories only changed when we move or
rename them?  And therefore, isn't it impossible for it to have changed
since the first commit?  So shouldn't we use the revision-id of the
first commit?

The lack of a revision_id was the reason we were talking about upgrading
repositories for nested-trees.

> We could also change commit to start recording changes to the root the
> same way it records changes to other directories.

I am definitely in favour of that, but I believe it's an inventory (and
therefore repository) format change.

> I'm seeking a +1 on the former reasonably urgently, so that the dirstate
> serialiser can do something sane

One option would be to use NOT_REVISION until such data is available.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFEyLuQ0F+nu1YWqI0RAvVlAJ9wBbGdtzz+M7D7fijxxKpXhPzudgCeJuDF
yeyKFVY0ZCko0nHaTpOY58o=
=dX8a
-----END PGP SIGNATURE-----