[MERGE] Make cmd_branch check the destination before doing any I/O on the source.

Michael Ellerman michael at ellerman.id.au
Wed Jul 26 02:06:07 BST 2006


On Tue, 2006-07-25 at 13:48 -0500, John Arbash Meinel wrote:
> The only thing it really means is that if we get an exception, and then
> delete_tree() also raises, it will hide the original exception.
> The only way I know around it is:
> 
> except Exception, e:
>   try:
>     to_transport.delete_tree('.')
>   except:
>     raise e
>   raise
> 
> That will raise the original exception delete_tree() fails, though you
> lose the traceback. And if delete_tree() succeeds, it raises the
> original exception with the original traceback.

I'll do that.

> Otherwise, I'm happy with the patch. I should probably review the whole
> thing, though, rather than just this part.

Don't bother, I'll ping you when I've fixed it up.

cheers
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060726/f84b2048/attachment.pgp 


More information about the bazaar mailing list