[MERGE] compare_trees with all unknowns

John Arbash Meinel john at arbash-meinel.com
Fri Jul 21 16:18:20 BST 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

We currently have a bug in 'bzr status' if you supply a path to an
unknown file.

https://launchpad.net/products/bzr/+bug/53638

Basically, 'compare_trees' only operates on versioned files, so if you
pass a 'specific_files' list with only unversioned files, it sees no
files to work on, and does a full compare.

While I was at it, I was very surprised to see that we don't have any
direct tests of 'compare_trees'. Considering it is one of our workhorse
functions I added what I consider a good starting set of tests. (I don't
test all the permutations of specific file lists and
add/modified/removed/etc) But I test each individually.

Anyway, the attached patch reveals the bug for compare_trees, and fixes
it. It doesn't test that 'status' does the right thing, but since 'bzr
status' was exposing the bug the compare_trees, I think this is okay.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEwPA8JdeBCYSNAAMRAmluAKCBJqKseEP3qMASXAwaRZPyYrb6xgCeJVeJ
x1m4uLaay6ny65IVHzLowy0=
=naje
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: compare-unknown-trees-53638.patch
Type: text/x-patch
Size: 20223 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060721/55ee62f6/attachment.bin 


More information about the bazaar mailing list