[patch] bzrtools should not append to DEFAULT_IGNORE

John Arbash Meinel john at arbash-meinel.com
Fri Jul 21 15:01:53 BST 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Adeodato Simó wrote:
> * John Arbash Meinel [Fri, 21 Jul 2006 08:12:11 -0500]:
> 
>> The attached patch is a fix for bzrtools to avoid the current
>> DEPRECATION warnings that we get since my ignore changes landed.
> 
> In 20060718061531.GA6726 at gifted Martin recommended to use version_info
> instead, so in case somebody likes it better, attached is the patch that
> I applied to my bzrtools copy when the ignore changes landed.
> 

Well, this fails on versions of bzr.dev < 1877, which report version =
0.9-dev, but do not have bzrlib.ignores (was introduced in 1871), and
then between 1871 and 1877, which does not have 'add_runtime_ignores'.

Which is why I was using direct inspection of what functions/modules are
available, rather than just a version number.

For official releases, it is reasonable to check 'bzrlib.version_info',
but for dev releases we need finer granularity.

(And it doesn't work to just check the revno, because I might be using
an integration or feature branch, which may or may not have merged that
bzr.dev version).

Long term, it only matters that 'bzrtools-0.9' is compatible with
'bzr.dev-0.9'. I can always use my hacked bzrtools until that happens.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEwN5RJdeBCYSNAAMRAhspAJ9SqRbDqzOGZO+RQkv/aEi1cPRpGQCgtFDz
/3wpDbMqC+xzpcmhCMtf6JQ=
=xu8t
-----END PGP SIGNATURE-----




More information about the bazaar mailing list