[MERGE] deprecated EmptyTree

[Robert Collins]

On Thu, 2006-07-20 at 09:28 -0500, John Arbash Meinel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Robert Collins wrote:
> > This patch deprecated EmptyTree, replacing all uses of it with a
> > RevisionTree.
> > 
> > The first thing is that as a tree, EmptyTree is really very pathological
> > - all the methods are essentially special cases. So its very hard to
> > test, because you can only ever have the Empty case of it.
> > 
> > The second thing is that in terms of code maintenance, we would have one
> > less thing to maintain if we use RevisionTree instead - as this patch
> > does.
> > 
> > Thoughts? +1's ?
> > 
> > -Rob
> > 
> 
> 1) I don't think we need EmptyTree, you are right to just use an empty
> RevisionTree
> 
> 2) We shouldn't really be using None to reference the EmptyTree (pending
> the discussion in the other thread). But if you are just trying to fix
> *this* problem, without fixing *that* one...

...
> So as long as we get that sorted out soon, I'm +1 to your changes. But
> it might be nicer to wait until we get the EMPTY/NULL/etc stuff sorted out.

I want both done, but for dirstate I only need 1) done, not 2). So lets
not conflate separate things.

Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060721/53bef3ab/attachment.pgp