[attn aaron] differences between RevisionTree and WorkingTree

Robert Collins robertc at robertcollins.net
Thu Jul 20 23:48:45 BST 2006


On Thu, 2006-07-20 at 09:25 -0500, John Arbash Meinel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Robert Collins wrote:
> > On Thu, 2006-07-20 at 09:31 -0400, Aaron Bentley wrote:
> >> -----BEGIN PGP SIGNED MESSAGE-----
> >> Hash: SHA1
> >>
> >> Robert Collins wrote:
> >>> Heres an interesting little quirk - 
> >>> I'd like to make this consistent in some manner - Aaron, what would work
> >>> best with your tree root work ?
> >> The RevisionTree behaviour would be best.  One of the pushes of the
> >> nested-trees work is to make the root entry as similar to the other
> >> entries as possible.
> > 
> > Looks to me like the cleanest way to fix this is for
> > inventory.iter_entries() to yield self.root as well as the other
> > elements.
> > 
> > That sound ok to everyone ?
> > 
> > Rob
> 
> I think we can do it tentatively, and explore the consequences. It
> sounds like a good thing to do in general.
> 
> I know that 'delta.py' is going to say that your first revision has an
> 'added' file of ''.

No it wont :). Because empty tree has the root too.

> So just doing 'bzr init; bzr status' is going to say there is something
> there. And since the string is empty, it isn't clear what was added.
> We really should give a better message. But that means 'root' is special
> cased again ....
> 
> Anyway, I'd be happy to see this. Just feel it has some longer reaching
> implications.

Well, I'll do it and see what breaks.

Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060721/8293102b/attachment.pgp 


More information about the bazaar mailing list