[MERGE] Remove interdependency between WorkingTree and RevisionTree

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Wouter van Heyst wrote:
> On Mon, Jul 17, 2006 at 09:41:34AM -0500, John Arbash Meinel wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>

...

>> Because RevisionTree expects everything to be in a Weave (it uses
>> get_*_weave() directly from the Repository).
>>
>> And creating a VersionedFile from SVN is expensive. Versus what
>> RevisionTree actually needs.
> 
> So why is RevisionTree depending on weaves? Backwards compatibility?
> 
> Wouter van Heyst

Not Weave specifically. VersionedFiles, though. Which are knits/weaves.
I'm just re-iterating what Jelmer has told me, and I'm not sure that he
has dug thoroughly into it.

I know for him to implement the full VersionedFile api, it is expensive.
But it certainly is possible he could implement part of it cheaply.
(Getting annotated lines, etc is expensive from SVN).

Regardless of that, I think it is a little bit of a layering violation
to have WorkingTree directly creating a RevisionTree, which should come
from Repository. But it isn't a 100% violation. I don't think we have
any other producers, though.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEu6yVJdeBCYSNAAMRAqVSAKCm5TEyrjG6oX8aqe8VSYQYNAgITACbBJBz
3M6FMZk8Z182sdyhvmhDuLw=
=FAD9
-----END PGP SIGNATURE-----