[MERGE] Remove interdependency between WorkingTree and RevisionTree

John Arbash Meinel john at arbash-meinel.com
Mon Jul 17 15:41:34 BST 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
> John Arbash Meinel wrote:
>>> The old code created a RevisionTree directly, but to do a lightweight
>>> bzr checkout of an svn repo, Jelmer needs to create an SVNRevisionTree,
>>> rather than a bzr RevisionTree, because it is attached to the
>>> repository, re-using Repository.revision_tree seemed a better way to
>>> factor it, rather than having WorkingTree explicitly depend on RevisionTree.
> 
> Personally, I'd really like to know why an SVNRevisionTree is necessary.
>  RevisionTree is basically a client of the public Repository interface,
> so you would think an SVNRepository would be fine.
> 
> I'm not against having an SVNRevisionTree, I'd just like to know why, so
> we can determine whether RevisionTree should be adjusted to make it more
> generic.
> 
> Aaron

Because RevisionTree expects everything to be in a Weave (it uses
get_*_weave() directly from the Repository).

And creating a VersionedFile from SVN is expensive. Versus what
RevisionTree actually needs.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEu6GdJdeBCYSNAAMRAi9aAJ9+fc/t4aKPj5nbatL8wi5+lFcU7QCeIupl
li2QpvSbH3Vtx2/gEyXv3Iw=
=6duJ
-----END PGP SIGNATURE-----




More information about the bazaar mailing list